Skip to content

tests: retry 'create_instance_with_processing_units' on 429 #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 4 commits into from
Jul 19, 2021
Merged

tests: retry 'create_instance_with_processing_units' on 429 #419

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0bf297
tests: retry 'create_instance_with_processing_units' on 429
tseaver Jul 16, 2021
aaf9bc6
chore: typo
tseaver Jul 16, 2021
99b4e56
Merge branch 'master' into 416-snippets-retry-instance-creation
tseaver Jul 19, 2021
f5404d6
tests: set initial retry delay for instance creation to 15 seconds
tseaver Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion samples/samples/snippets_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@
import time
import uuid

from google.api_core import exceptions
from google.cloud import spanner
from google.cloud.spanner_v1.instance import Backup
from google.cloud.spanner_v1.instance import Instance
import pytest
from test_utils.retry import RetryErrors

import snippets

Expand Down Expand Up @@ -84,7 +86,10 @@ def test_create_instance(spanner_instance):

def test_create_instance_with_processing_units(capsys):
processing_units = 500
snippets.create_instance_with_processing_units(LCI_INSTANCE_ID, processing_units)
retry_429 = RetryErrors(exceptions.ResourceExhausted, delay=15)
retry_429(snippets.create_instance_with_processing_units)(
LCI_INSTANCE_ID, processing_units,
)
out, _ = capsys.readouterr()
assert LCI_INSTANCE_ID in out
assert "{} processing units".format(processing_units) in out
Expand Down