Skip to content

tests: move systests into separate modules, refactor using pytest #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larkee merged 19 commits into from
Aug 11, 2021
Merged

tests: move systests into separate modules, refactor using pytest #474

larkee merged 19 commits into from
Aug 11, 2021

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 30, 2021

Replaces the existing legacy setup / teardown code with pytest fixtures.

Closes #472.

tseaver added 8 commits July 29, 2021 19:08
@tseaver
tests: move instance API systests to own module
fabe90f 
Refactor to use pytest fixtures / idioms, rather than old 'Config'
setup / teardown.

Toward #472.
@tseaver
tests: move database API systests to own module
26c9de0 
Refactor to use pytest fixtures / idioms, rather than old 'Config'
setup / teardown.

Toward #472.
@tseaver
tests: move table API systests to own module
e38267b 
Refactor to use pytest fixtures / idioms, rather than old 'Config'
setup / teardown.

Toward #472.
@tseaver
tests: move backup API systests to own module [WIP]
4f1c5b2 
Refactor to use pytest fixtures / idioms, rather than old 'Config'
setup / teardown.

Toward #472.
@tseaver
tests: move streaming/chunnking systests to own module
83c7201 
Refactor to use pytest fixtures / idioms, rather than old 'Config'
setup / teardown.

Toward #472.
@tseaver
tests: move session API systests to own module
6867cd6 
Refactor to use pytest fixtures / idioms, rather than old 'Config'
setup/ teardown.

Toward #472.
@tseaver
tests: move dbapi systests to owwn module
ab9901f 
Refactor to use pytest fixtures / idioms, rather than old 'Confog'
setup / teardown.

Toward #472.
@tseaver
tests: remove legacy systest setup / teardown code
b085c22 
Closes #472.
@tseaver tseaver requested a review from larkee July 30, 2021 21:30
@tseaver tseaver requested a review from a team as a code owner July 30, 2021 21:30
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jul 30, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jul 30, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 11 region tags.
You are about to delete 11 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 30, 2021
@tseaver
Copy link
Contributor Author

tseaver commented Jul 30, 2021 •
edited
Loading

A couple of notes on this PR:

  • The backup systests are so slow, and occasionally flaky, that they may still need further hardening / tweaking.
  • I see that the tests are failing under the emulator. I need to work out how to run it locally to fix that. Done.

@tseaver tseaver marked this pull request as draft July 30, 2021 21:35
@tseaver tseaver marked this pull request as ready for review July 31, 2021 21:14
larkee
larkee reviewed Aug 9, 2021
View reviewed changes
@larkee larkee merged commit 5629bac into master Aug 11, 2021
@larkee larkee deleted the 472-refactor-harden-systests branch August 11, 2021 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larkee larkee larkee approved these changes

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor systests into separate modules, using pytest fixtures / idioms

2 participants

@tseaver @larkee