feat: add if*generation*Match support, pt2 #126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaFaer
added
api: storage
googlebot
added
the
cla: yes
IlyaFaer
requested review from
crwilcox and
frankyn
and removed request for
frankyn
Author
|
This branch was created from the first part. It contains almost the same amount of lines changed. Anyway, it can be merged into the first part, if it's more convenient in any sense. |
Author
|
Changes are merged into the first part: #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
if*generation*matchargs into methods:Blob.download_to_file()Blob.download_to_filename()Blob.download_as_string()Blob.rewrite()Blob.update_storage_class()Bucket.copy_blob()Towards #127