Skip to content

Conversation

@bcoe
Copy link

@bcoe bcoe commented May 1, 2019

  1. release-please uses async iterators, so I've removed Node8 and Node6 builds.
  2. we're experimenting with using c8 for coverage rather than nyc.
  • fix issue with c8 on node10 (node10 still has issues with c8 related to its wrapper length, a fix for this just landed).
  • c8 needs to have support for --report-directory added, so that we're able to switch the report directory to .coverage.

@bcoe bcoe changed the title test: getting CI running build: getting CI running May 1, 2019
@bcoe bcoe changed the title build: getting CI running [WIP] build: getting CI running May 1, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2019
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2019
@bcoe bcoe changed the title [WIP] build: getting CI running build: getting CI running May 3, 2019
@bcoe bcoe merged commit 95458f9 into master May 3, 2019
@bcoe bcoe deleted the fix-build branch May 3, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants