-
Notifications
You must be signed in to change notification settings - Fork 70
fix(spring): add parent and remove maven-jar-plugin from pom string. #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
|
Kudos, SonarCloud Quality Gate passed!
|
|
A somewhat relevant thought that doesn't have to be addressed in this PR: would it make sense to have I was looking into replacing the content string with some sort of templating here, but It seems like the generated file is already pretty much a template (only parsed apiShortName comes from the generator, and we can probably find a better substitute for that in post-processing). Not sure if I'm missing anything here though - @zhumin8 what do you think? |
diegomarquezp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Following @emmileaf 's line, a good patter would be that of rules_gapic if we want to use templates for the pom.
|
On the template note, haven't looked closely at @diegomarquezp's suggestion yet, but can we do something similar to client_grpcrest.gradle.tmpl? |








Two changes:
generated-parent. This parent pom is manually created inspring-cloud-gcp/generated.maven-jar-pluginas module will inherit from spring parent.