Skip to content

fix(spring): change @Generated description to spring specific. #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhumin8 merged 3 commits into from
Dec 1, 2022
Merged

fix(spring): change @Generated description to spring specific. #1103

zhumin8 merged 3 commits into from
Dec 1, 2022

Conversation

@zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Nov 29, 2022 •
edited
Loading

change @Generated description to spring specific and separate from "gapic-generator-java" for client libraries.
Also moved relevant annotation from SpringPackageInfoComposer to SpringComposer.

@zhumin8 zhumin8 requested a review from a team November 29, 2022 20:07
@zhumin8 zhumin8 requested a review from a team as a code owner November 29, 2022 20:07
@zhumin8 zhumin8 mentioned this pull request Nov 29, 2022
Closed
5 tasks
@emmileaf
Copy link
Contributor

emmileaf commented Nov 29, 2022

Couldn't figure out how to add suggestions to unchanged files, but this description is also set in SpringPackageInfoComposer (and SpringPackageInfo.golden). Could you help make the quick change in this PR? Thanks!

blakeli0
blakeli0 reviewed Nov 30, 2022
View reviewed changes
src/main/java/com/google/api/generator/spring/composer/SpringComposer.java Outdated
AnnotationNode.builder()
.setType(FIXED_TYPESTORE.get("Generated"))
.setDescription("by gapic-generator-java")
.setDescription("by spring-generator-java")
Copy link
Contributor

@blakeli0 blakeli0 Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we want to call the spring auto config generator once we move the code to spring-cloud-gcp? Maybe we should come up with a long term name and stick to it, spring-generator-java seems a little odd to me. Maybe spring-auto-config-generator or just a generic spring-generator?

Copy link
Contributor Author

@zhumin8 zhumin8 Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions. spring-generator sounds better to me, to keep it open to expanding beyond auto-config in future.

Copy link
Member

@meltsufin meltsufin Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add "google" somewhere in there? For instance, google-cloud-spring-generator?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zhumin8 zhumin8 merged commit 59ecb5b into autoconfig-gen-draft2 Dec 1, 2022
@zhumin8 zhumin8 deleted the generated-description branch December 1, 2022 20:15
@zhumin8 zhumin8 added the spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch. label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meltsufin meltsufin meltsufin left review comments

@blakeli0 blakeli0 blakeli0 approved these changes

@diegomarquezp diegomarquezp Awaiting requested review from diegomarquezp

+1 more reviewer

@emmileaf emmileaf emmileaf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhumin8 @emmileaf @blakeli0 @meltsufin