Skip to content

Conversation

@emmileaf
Copy link
Contributor

@emmileaf emmileaf commented Dec 1, 2022

This PR is superseded by #1171.

This PR is a follow-up on GoogleCloudPlatform/spring-cloud-gcp#1364 (comment), and adds Javadoc comments to configurable properties.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Dec 1, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@emmileaf emmileaf added the spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch. label Dec 1, 2022
@emmileaf
Copy link
Contributor Author

Rebasing on top of #1143, since previous approach for retry properties comments is no longer applicable

@emmileaf emmileaf force-pushed the spring-properties-javadoc branch from 4e803eb to 6d6d01e Compare December 19, 2022 17:01
@emmileaf emmileaf changed the base branch from autoconfig-gen-draft2 to spring-refactor-retry-properties-2 December 19, 2022 17:02
@emmileaf emmileaf changed the base branch from spring-refactor-retry-properties-2 to autoconfig-gen-draft2 December 20, 2022 14:57
@emmileaf emmileaf changed the base branch from autoconfig-gen-draft2 to spring-refactor-retry-properties-2 December 20, 2022 15:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@emmileaf emmileaf marked this pull request as ready for review December 20, 2022 21:49
@emmileaf emmileaf requested a review from a team as a code owner December 20, 2022 21:49
Base automatically changed from spring-refactor-retry-properties-2 to autoconfig-gen-draft2 December 20, 2022 21:55
@emmileaf emmileaf marked this pull request as draft December 20, 2022 22:08
@emmileaf
Copy link
Contributor Author

Managed to get this PR stuck in rebasing mess...closing and trying again in #1171.

@emmileaf emmileaf closed this Dec 20, 2022
@emmileaf emmileaf deleted the spring-properties-javadoc branch April 21, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant