Skip to content

Conversation

@emmileaf
Copy link
Contributor

@emmileaf emmileaf commented Dec 15, 2022

This PR goes together with GoogleCloudPlatform/spring-cloud-gcp#1392 and:

  • Refactors the current setup with method-level and individual settings to use a nested Retry object provided through properties at service-level.

    • Previously, configuring per-setting and per-method :
    <prefix>.language-service.annotate-text-retry-delay-multiplier=2
    <prefix>.language-service.annotate-text-max-retry-delay=PT0.9S
    
    • With this PR, settings provided at service-level will be applied to all rpc methods:
    <prefix>.language-service.retry-settings.retry-delay-multiplier=2
    <prefix>.language-service.retry-settings.max-retry-delay=PT0.9S
    
  • Adding method-level property configuration for retry settings will be made incrementally in another PR.

@emmileaf emmileaf added the spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch. label Dec 15, 2022
@emmileaf emmileaf marked this pull request as ready for review December 15, 2022 21:04
@emmileaf emmileaf requested a review from a team December 15, 2022 21:04
@emmileaf emmileaf requested a review from a team as a code owner December 15, 2022 21:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@emmileaf
Copy link
Contributor Author

Closing in favor of #1143, which extends on top of these commits and adds method-level properties configuration.

@emmileaf emmileaf closed this Dec 16, 2022
@emmileaf emmileaf deleted the spring-refactor-retry-properties branch April 21, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant