fix(spring): pom writer changes to adapt to repo structure changes in hosting repo #1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
|
Kudos, SonarCloud Quality Gate passed!
|
zhumin8
requested review from
blakeli0,
diegomarquezp,
emmileaf and
meltsufin
meltsufin
approved these changes
Dec 20, 2022
emmileaf
approved these changes
Dec 20, 2022
zhumin8
added a commit
to GoogleCloudPlatform/spring-cloud-gcp
that referenced
this pull request
Dec 29, 2022
This is part 1 of implementation for #1383. Changes include: - Change folder name for generator scripts to 'spring-cloud-generator' - generation script changes to adapt to new folder names. - `generate-one.sh` change to add generated module to `spring-cloud-gcp-starters` - Generated modules target destination renamed to `spring-cloud-previews` folder. - Changes to pom.xml to make it an aggregator for generated modules. - Moved `fmt-maven-plugin` to spring-cloud-gcp/pom with default set to skip. - Fix `spring-cloud-gcp-dependencies` version inheritance issue. - `spring-cloud-gcp-starters/pom.xml` format change: replaced tabs with whitespaces, added comment marker for inserting generated modules. Changes that needs to happen on the generator side: - generated module pom changes: googleapis/sdk-platform-java#1141 - use `spring-cloud-gcp-starters` as parent - Added `.preview` suffix to generated module versions.
zhumin8
added
the
spring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of implementation for repo structural changes in PoC.
Changes in Pom string:
spring-cloud-gcp-startersand version with "-preview" suffixCorresponding changes in spring-cloud-gcp: GoogleCloudPlatform/spring-cloud-gcp#1394