Skip to content

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented Dec 19, 2022

Work has been done in googleapis/gax-java#1878.

This is the result of the patch file and migrating the PRs to the GAPIC monorepo.

@lqiu96 lqiu96 requested a review from a team December 19, 2022 21:03
@lqiu96 lqiu96 requested a review from a team as a code owner December 19, 2022 21:03
@lqiu96 lqiu96 changed the title chore: Update to non-eager FutureListener feat: Update to non-eager FutureListener Dec 19, 2022
@lqiu96
Copy link
Member Author

lqiu96 commented Dec 19, 2022

ci / build (8) job failure:

Run echo "Building Storage lib from generated source..."
Building Storage lib from generated source...
(21:15:16) INFO: Current date is 2022-12-19
(21:[15](https://github.com/googleapis/gapic-generator-java/actions/runs/3735156598/jobs/6338068902#step:10:16):[16](https://github.com/googleapis/gapic-generator-java/actions/runs/3735156598/jobs/6338068902#step:10:17)) Loading: 
(21:15:16) Loading: 0 packages loaded
(21:15:[17](https://github.com/googleapis/gapic-generator-java/actions/runs/3735156598/jobs/6338068902#step:10:18)) Analyzing: target @com_google_googleapis//google/storage/v2:google-cloud-storage-v2-java (1 packages loaded, 0 targets configured)
(21:15:17) ERROR: /home/runner/work/gapic-generator-java/gapic-generator-java/rules_java_gapic/BUILD.bazel:7:8: //rules_java_gapic:gradlew: no such attribute 'extension' in '_real_pkg_tar' rule
(21:15:17) ERROR: /home/runner/work/gapic-generator-java/gapic-generator-java/rules_java_gapic/BUILD.bazel:7:8: //rules_java_gapic:gradlew: no such attribute 'files' in '_real_pkg_tar' rule
(21:15:17) ERROR: /home/runner/work/gapic-generator-java/gapic-generator-java/rules_java_gapic/BUILD.bazel:7:8: //rules_java_gapic:gradlew: no such attribute 'mode' in '_real_pkg_tar' rule
([21](https://github.com/googleapis/gapic-generator-java/actions/runs/3735156598/jobs/6338068902#step:10:22):15:17) ERROR: /home/runner/work/gapic-generator-java/gapic-generator-java/rules_java_gapic/BUILD.bazel:7:8: //rules_java_gapic:gradlew: no such attribute 'modes' in '_real_pkg_tar' rule
(21:15:17) ERROR: /home/runner/.cache/bazel/_bazel_runner/1f815583ebc8da6875b9074f31ba9a5d/external/com_google_googleapis/google/storage/v2/BUILD.bazel:93:31: Target '//rules_java_gapic:gradlew' contains an error and its package is in error and referenced by '@com_google_googleapis//google/storage/v2:google-cloud-storage-v2-java'
(21:15:17) ERROR: Analysis of target '@com_google_googleapis//google/storage/v2:google-cloud-storage-v2-java' failed; build aborted: Analysis failed
(21:15:17) INFO: Elapsed time: 1.981s
(21:15:17) INFO: 0 processes.
(21:15:17) FAILED: Build did NOT complete successfully (5 packages loaded, 5 targets configured)
Error: Process completed with exit code 1.

Investigating... Seems to be the same issue Tomo is experiencing in #1156

@suztomo
Copy link
Member

suztomo commented Dec 20, 2022

All checks are green except SonarCloud.

@lqiu96
Copy link
Member Author

lqiu96 commented Dec 20, 2022

All checks are green except SonarCloud.

Thanks for resolving the issue @suztomo! I've re-ran the Sonar check and it passed -- Seems like it was a transient issue.

CC: @blakeli0 Can you take a look at this when you get a chance?

Copy link
Contributor

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.9% 90.9% Coverage
0.0% 0.0% Duplication

@lqiu96 lqiu96 merged commit c7a1395 into main Dec 20, 2022
@lqiu96 lqiu96 deleted the main-update_to_noneager_futurelistener branch December 20, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants