fix: add name to ConditionalOnMissingBean when creating bean #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nelProvider bean.
zhumin8
added
the
spring
meltsufin
approved these changes
Jan 4, 2023
emmileaf
reviewed
Jan 4, 2023
src/main/java/com/google/api/generator/spring/composer/SpringAutoConfigClassComposer.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
emmileaf
approved these changes
Jan 4, 2023
zhumin8
added a commit
to GoogleCloudPlatform/spring-cloud-gcp
that referenced
this pull request
Jan 11, 2023
…ifier name. (#1418) This is a followup on #1355, the additional test verifies in case of multiple bean of type `TransportChannelProvider` the one with correct qualifier name is used. related fix in generator: googleapis/sdk-platform-java#1207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add name to
@ConditionalOnMissingBeanannotation when creatingTransportChannelProviderbean so that it can be picked up with Qualifier in serviceSettings bean creation that follows.This was missed in original commit adding this bean and should fix error seen in GoogleCloudPlatform/spring-cloud-gcp#1407 (comment)