-
Notifications
You must be signed in to change notification settings - Fork 70
feat: add ThisObjectValue #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+155
−0
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
10b293b
Add ThisObjectValue
summer-ji-eng faa9367
Add unit test
summer-ji-eng 35eb16a
Add ThisObjectValue usage example in writervisitor test
summer-ji-eng 434b8d8
Add license
summer-ji-eng 3b77f64
add license and rename a function
summer-ji-eng 121f405
Add ThisObjectValue
summer-ji-eng 9c5fb8b
Add unit test
summer-ji-eng 29fa1a0
Add ThisObjectValue usage example in writervisitor test
summer-ji-eng 13b842e
Add license
summer-ji-eng 2f1d1b4
add license and rename a function
summer-ji-eng f3b533d
use buildin function
summer-ji-eng fc9f01a
merge
summer-ji-eng 109cf32
fix the merge msg
summer-ji-eng 2af92af
Address the comments
summer-ji-eng f2e5983
correct the test name and add overwrite
summer-ji-eng b759255
clear error msg
summer-ji-eng 340553c
formatting
summer-ji-eng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
54 changes: 54 additions & 0 deletions
54
src/main/java/com/google/api/generator/engine/ast/ThisObjectValue.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // Copyright 2020 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.api.generator.engine.ast; | ||
|
|
||
| import com.google.auto.value.AutoValue; | ||
| import com.google.common.base.Preconditions; | ||
|
|
||
| @AutoValue | ||
| public abstract class ThisObjectValue implements ObjectValue { | ||
| private static final String THIS_VALUE = "this"; | ||
|
|
||
| @Override | ||
| public abstract TypeNode type(); | ||
|
|
||
| @Override | ||
| public String value() { | ||
| return THIS_VALUE; | ||
| } | ||
|
|
||
| public static ThisObjectValue withType(TypeNode type) { | ||
| return builder().setType(type).build(); | ||
| } | ||
|
|
||
| private static Builder builder() { | ||
| return new AutoValue_ThisObjectValue.Builder(); | ||
| } | ||
|
|
||
| @AutoValue.Builder | ||
| abstract static class Builder { | ||
| abstract Builder setType(TypeNode type); | ||
|
|
||
| abstract ThisObjectValue autoBuild(); | ||
|
|
||
| private ThisObjectValue build() { | ||
| ThisObjectValue thisObjectValue = autoBuild(); | ||
| Preconditions.checkState( | ||
| TypeNode.isReferenceType(thisObjectValue.type()), | ||
| "The \"this\" object can only refer to object types"); | ||
| return thisObjectValue; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
src/test/java/com/google/api/generator/engine/ast/ThisObjectValueTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // Copyright 2020 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.api.generator.engine.ast; | ||
|
|
||
| import static org.junit.Assert.assertThrows; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| public class ThisObjectValueTest { | ||
| @Test | ||
| public void validThisObjectValue_basic() { | ||
| VaporReference ref = | ||
| VaporReference.builder() | ||
| .setName("Student") | ||
| .setPakkage("com.google.example.examples.v1") | ||
| .build(); | ||
| TypeNode typeNode = TypeNode.withReference(ref); | ||
| ThisObjectValue.withType(typeNode); | ||
| // No exception thrown, we're good. | ||
| } | ||
|
|
||
| @Test | ||
| public void invalidThisObjectValue_nonReferenceType() { | ||
| assertThrows( | ||
| IllegalStateException.class, | ||
| () -> { | ||
| ThisObjectValue.withType(TypeNode.DOUBLE); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| public void invalidThisObjectValue_nullType() { | ||
| assertThrows( | ||
| IllegalStateException.class, | ||
| () -> { | ||
| ThisObjectValue.withType(TypeNode.NULL); | ||
| }); | ||
| } | ||
| } | ||
summer-ji-eng marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.