Skip to content

chore: add showcase test for server-side with gRPC transport #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpeddada1 merged 15 commits into from
Mar 24, 2023
Merged

chore: add showcase test for server-side with gRPC transport #1502

mpeddada1 merged 15 commits into from
Mar 24, 2023

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Mar 16, 2023

Thank you for opening a Pull Request! For general contributing guidelines, please refer to contributing guide

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Mar 16, 2023
@mpeddada1 mpeddada1 changed the title chore: add test for server-side streaming with gRPC transport chore: add test for server-side streaming showcase test with gRPC transport Mar 16, 2023
@mpeddada1 mpeddada1 changed the title chore: add test for server-side streaming showcase test with gRPC transport chore: add showcase test for server-side with gRPC transport Mar 17, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Mar 22, 2023
@mpeddada1 mpeddada1 marked this pull request as ready for review March 22, 2023 21:09
@mpeddada1 mpeddada1 requested a review from a team as a code owner March 22, 2023 21:09
@mpeddada1 mpeddada1 requested a review from burkedavison March 23, 2023 16:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 23, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 23, 2023

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 23, 2023

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

lqiu96
lqiu96 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@lqiu96 lqiu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mpeddada1! Will add a HttpJson version.

@mpeddada1 mpeddada1 merged commit 461a4e5 into main Mar 24, 2023
@mpeddada1 mpeddada1 deleted the server-side-grpc branch March 24, 2023 18:34
@mpeddada1 mpeddada1 mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

@burkedavison burkedavison burkedavison approved these changes

Assignees

No one assigned

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpeddada1 @lqiu96 @burkedavison