Skip to content

Conversation

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Jun 26, 2023

Notable Changes:

  • This PR leverages the Writer class to parse necessary information such as package name and class name from the collection of GapicClass objects that are returned by the Composer. It then uses that information to generated a reflect-config.json file.
  • The drawback of this change is that it only includes a subset of classes, particularly, the ones generated by the gapic generator. We need to also include the classes that are generated by the standard java_proto_library bazel rule.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 26, 2023
@mpeddada1 mpeddada1 changed the title fix: generate native image configurations for Gapic classes fix: generate native image configurations for Gapics Jun 26, 2023
@sonarqubecloud
Copy link

[gapic-generator-java-root] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@burkedavison burkedavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the other PR, (if we want to continue considering this option) let's please update this PR to:

  • Apply to showcase
  • Invoke the showcase native image tests
  • Remove the RunReachabilityHandlersConcurrently argument
  • Remove the Feature classes using reachability handlers

@mpeddada1
Copy link
Contributor Author

Closing in favor of #1841

@mpeddada1 mpeddada1 closed this Jul 24, 2023
@mpeddada1 mpeddada1 deleted the graal-config-generation branch July 24, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants