Skip to content

chore: update showcase version #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoeWang1127 merged 4 commits into from
Nov 13, 2023
Merged

chore: update showcase version #2234

JoeWang1127 merged 4 commits into from
Nov 13, 2023

Conversation

@JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Nov 10, 2023 •
edited
Loading

In this PR:

  • Update showcase version to 0.29.0.
  • Update showcase client.

@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Nov 10, 2023
@JoeWang1127 JoeWang1127 changed the title chore: add integration tests chore: update showcase version Nov 10, 2023
@JoeWang1127 JoeWang1127 linked an issue Nov 10, 2023 that may be closed by this pull request
Add test for new Showcase ErrorEchoDetails RPC #2229
Closed
3 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 10, 2023

[gapic-generator-java-root] SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 107 Code Smells

2.5% 2.5% Coverage
23.8% 23.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 10, 2023

[java_showcase_integration_tests] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

74.2% 74.2% Coverage
5.9% 5.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@JoeWang1127
Copy link
Contributor Author

JoeWang1127 commented Nov 10, 2023

Should I worry about ci/showcase-clirr check?

@JoeWang1127 JoeWang1127 marked this pull request as ready for review November 10, 2023 22:31
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner November 10, 2023 22:31
@burkedavison
Copy link
Member

burkedavison commented Nov 10, 2023

No, we don't care about clirr in this case since we are deliberately changing the showcase source and there are no downstream compatibility concerns with this. Clirr check can be ignored here.

@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 13, 2023
@JoeWang1127 JoeWang1127 merged commit 9d30ed9 into main Nov 13, 2023
@JoeWang1127 JoeWang1127 deleted the chore/add-integration-tests branch November 13, 2023 17:08
@alicejli alicejli mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burkedavison burkedavison burkedavison approved these changes

Assignees

No one assigned

Labels

size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add test for new Showcase ErrorEchoDetails RPC

2 participants

@JoeWang1127 @burkedavison