feat: add a github client by JoeWang1127 · Pull Request #2747 · googleapis/sdk-platform-java

JoeWang1127 · 2024-05-07T15:00:41Z

In this PR:

Add a github client to retrieve pull request status from a repository.
Add unit test.

suztomo

Would you add brief Javadoc for future maintainers?

suztomo · 2024-05-15T13:08:06Z

java-shared-dependencies/dependency-analyzer/pom.xml

+        <version>3.2.5</version>
+        <configuration>
+          <environmentVariables>
+            <GITHUB_TOKEN>fake_value</GITHUB_TOKEN>


Add source code comment how it helps tests.

suztomo · 2024-05-15T13:08:44Z

...d-dependencies/dependency-analyzer/src/main/java/com/google/cloud/external/GitHubClient.java

+import java.util.List;
+import java.util.Objects;
+
+public class GitHubClient {


Can you add Javadoc?

suztomo · 2024-05-15T13:09:03Z

...-dependencies/dependency-analyzer/src/main/java/com/google/cloud/external/DepsDevClient.java

@@ -29,7 +29,7 @@
 public class DepsDevClient {


Can you add Javadoc?

suztomo · 2024-05-15T13:09:59Z

...dependencies/dependency-analyzer/src/main/java/com/google/cloud/model/PullRequestStatus.java

@@ -0,0 +1,5 @@
+package com.google.cloud.model;
+
+public record PullRequestStatus(long created, long merged, Interval interval) {


Can you add Javadoc, especially which part of the dependency report this helps, with an example value.

We can change the class name to PullRequestStatistics.

suztomo

Can you run the google-java-format formatter?

git diff -U0 origin/main |google-java-format-diff.py -p1 -i

The formatter does not merge multiple lines. Ensure you read the formatted files.

suztomo · 2024-05-16T14:29:38Z

...d-dependencies/dependency-analyzer/src/main/java/com/google/cloud/external/GitHubClient.java

+ * GitHubClient is a class that sends HTTP requests to the GitHub RESTful API.
+ * It provides methods for interacting with various GitHub resources such as repositories,
+ * issues, users, etc.
+ * <p>


New line before <p>. No new line after <p>. https://google.github.io/styleguide/javaguide.html#s7.1.2-javadoc-paragraphs

I formatted the code using

git diff -U0 origin/main | python google-java-format-diff.py -p1 -i

sonarqubecloud · 2024-05-16T14:47:28Z

Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud · 2024-05-16T14:50:40Z

Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

In this PR: - Add a github client to retrieve pull request status from a repository. - Add unit test.

🤖 I have created a release *beep* *boop* --- <details><summary>2.41.0</summary> ## [2.41.0](v2.40.1...v2.41.0) (2024-05-31) ### Features * add a github client ([#2747](#2747)) ([f8ea0a0](f8ea0a0)) * generate proto-only repository ([#2720](#2720)) ([f7a5161](f7a5161)) ### Bug Fixes * [#2785](#2785). ([599f5da](599f5da)) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v2.6.0 ([#2782](#2782)) ([5bc8928](5bc8928)) * update dependency com.google.cloud.opentelemetry:detector-resources-support to v0.29.0 ([#2831](#2831)) ([6c1dbfc](6c1dbfc)) * update dependency com.google.code.gson:gson to v2.11.0 ([#2786](#2786)) ([91f3254](91f3254)) * update dependency com.google.code.gson:gson to v2.11.0 ([#2787](#2787)) ([e81893c](e81893c)) * update dependency com.google.errorprone:error_prone_annotations to v2.28.0 ([#2835](#2835)) ([b8f11b1](b8f11b1)) * update dependency com.google.errorprone:error_prone_annotations to v2.28.0 ([#2838](#2838)) ([5c46f3f](5c46f3f)) * update dependency net.bytebuddy:byte-buddy to v1.14.16 ([#2797](#2797)) ([dfedafc](dfedafc)) * update dependency net.bytebuddy:byte-buddy to v1.14.17 ([#2828](#2828)) ([6eb9041](6eb9041)) * update dependency org.checkerframework:checker-qual to v3.43.0 ([#2730](#2730)) ([b7fa736](b7fa736)) * update dependency requests to v2.32.0 [security] ([#2791](#2791)) ([c2ea6cc](c2ea6cc)) * update dependency watchdog to v4.0.1 ([#2800](#2800)) ([d5771dd](d5771dd)) * update google api dependencies ([#2672](#2672)) ([6643536](6643536)) * update google http client dependencies to v1.44.2 ([#2783](#2783)) ([dee7e00](dee7e00)) * update googleapis/java-cloud-bom digest to 59c776b ([#2827](#2827)) ([03b3eb4](03b3eb4)) * update netty dependencies to v4.1.110.final ([#2796](#2796)) ([d1aaa68](d1aaa68)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

feat: add a github client

eac03e5

product-auto-label bot added the size: m Pull request size is medium. label May 7, 2024

JoeWang1127 added 3 commits May 14, 2024 17:10

Merge branch 'main' into feat/add-github-client

7342592

add unit tests

b47e357

remove main

33cc9b8

JoeWang1127 marked this pull request as ready for review May 15, 2024 00:46

JoeWang1127 requested review from a team and suztomo May 15, 2024 00:46

Merge branch 'main' into feat/add-github-client

d5a2e9a

suztomo reviewed May 15, 2024

View reviewed changes

add javadoc

87b2f78

product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 16, 2024

Merge branch 'main' into feat/add-github-client

fe7eec9

JoeWang1127 requested a review from suztomo May 16, 2024 13:51

suztomo approved these changes May 16, 2024

View reviewed changes

suztomo reviewed May 16, 2024

View reviewed changes

format code

a7676fe

JoeWang1127 merged commit f8ea0a0 into main May 16, 2024

JoeWang1127 deleted the feat/add-github-client branch May 16, 2024 15:37

release-please bot mentioned this pull request May 16, 2024

chore(main): release 2.41.0 #2780

Closed

lqiu96 pushed a commit that referenced this pull request May 16, 2024

feat: add a github client (#2747)

83c0dbb

In this PR: - Add a github client to retrieve pull request status from a repository. - Add unit test.

lqiu96 pushed a commit that referenced this pull request May 22, 2024

feat: add a github client (#2747)

80cc1f7

In this PR: - Add a github client to retrieve pull request status from a repository. - Add unit test.

release-please bot mentioned this pull request May 24, 2024

chore(main): release 2.41.0 #2820

Merged

		@@ -0,0 +1,5 @@
		package com.google.cloud.model;

		public record PullRequestStatus(long created, long merged, Interval interval) {

Conversation

JoeWang1127 commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suztomo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suztomo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented May 16, 2024

Quality Gate passed for 'gapic-generator-java-root'

Uh oh!

sonarqubecloud bot commented May 16, 2024

Quality Gate passed for 'java_showcase_integration_tests'

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JoeWang1127 commented May 7, 2024 •

edited

Loading