Skip to content

chore: Add comment context on null protobuf check [ggj] #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miraleung merged 4 commits into from
Jun 9, 2021
Merged

chore: Add comment context on null protobuf check [ggj] #754

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db013de
chore: Add comment context on null protobuf check
miraleung Jun 7, 2021
8b9d883
Merge branch 'master' into miraleung-patch-1
miraleung Jun 7, 2021
868965e
Merge branch 'master' into miraleung-patch-1
miraleung Jun 9, 2021
6acd0cd
Update AbstractServiceStubSettingsClassComposer.java
miraleung Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .../google/api/generator/gapic/composer/common/AbstractServiceStubSettingsClassComposer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,14 @@ private static Expr createPagedListDescriptorAssignExpr(
String.format("get%sList", JavaStyle.toUpperCamelCase(repeatedFieldName)))
.setReturnType(returnType)
.build();

// While protobufs should not be null, this null-check is needed to protect against NPEs
// in paged iteration on clients that use legacy HTTP/JSON types, as these clients can
// actually return null instead of an empty list.
// Context:
// Original issue: https://github.com/googleapis/google-cloud-java/issues/3736
// Relevant discussion where this check was first added:
// https://github.com/googleapis/google-cloud-java/pull/4499#discussion_r257057409
Expr conditionExpr =
RelationalOperationExpr.equalToWithExprs(getResponsesListExpr, ValueExpr.createNullExpr());
Expr thenExpr =
Expand Down