Skip to content

Conversation

@zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Mar 2, 2022

This seems to be added setup in #936, but later accidentally deleted?

Verified test runs with command bazel run //:update_com_google_api_generator_engine_JavaCodeGeneratorTest

@zhumin8 zhumin8 requested a review from a team March 2, 2022 17:36
@zhumin8 zhumin8 requested a review from a team as a code owner March 2, 2022 17:36
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@meltsufin
Copy link
Member

@blakeli0 I think you removed it.

@blakeli0
Copy link
Contributor

blakeli0 commented Mar 3, 2022

This seems to be added setup in #936, but later accidentally deleted?

Verified test runs with command bazel run //:update_com_google_api_generator_engine_JavaCodeGeneratorTest

hmm, I removed it on purpose because it was failing other commands, but I just tested and they are working fine.
OK, so the one I removed was :gapic_generator_java-test, and the new line is :gapic_generator_java_test.

@blakeli0 blakeli0 merged commit 7ab9ae3 into main Mar 3, 2022
@blakeli0 blakeli0 deleted the fix-test-runtime-deps branch March 3, 2022 18:54
suztomo pushed a commit that referenced this pull request Mar 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit that referenced this pull request Mar 21, 2023
…960)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.protobuf:protobuf-bom](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.21.6` -> `3.21.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.7/compatibility-slim/3.21.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.7/confidence-slim/3.21.6)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>protocolbuffers/protobuf</summary>

### [`v3.21.7`](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.6...v3.21.7)

[Compare Source](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.6...v3.21.7)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release *beep* *boop*
---


## [2.8.18](https://togithub.com/googleapis/java-core/compare/v2.8.17...v2.8.18) (2022-09-30)


### Dependencies

* Update dependency com.google.protobuf:protobuf-bom to v3.21.7 ([#960](https://togithub.com/googleapis/java-core/issues/960)) ([1c38fb7](https://togithub.com/googleapis/java-core/commit/1c38fb77fc9b3a9510050ba9b78bcbf93c80d52c))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants