Skip to content

chore: avoid using implicitly declared samples target in BUILD.bazel #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eaball35 merged 2 commits into from
May 21, 2022
Merged

chore: avoid using implicitly declared samples target in BUILD.bazel #994

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5722ce6
chore: avoid using implictly declared target
eaball35 May 18, 2022
b39900c
use snake case
eaball35 May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions rules_java_gapic/java_gapic_pkg.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,7 @@ java_gapic_srcs_pkg = rule(
def java_gapic_assembly_gradle_pkg(
name,
deps,
include_samples = False,
assembly_name = None,
transport = None,
**kwargs):
Expand All @@ -341,9 +342,9 @@ def java_gapic_assembly_gradle_pkg(
processed_deps = {} #there is no proper Set in Starlark
for dep in deps:
# Use contains instead of endswith since microgenerator testing may use differently-named targets.
if "samples" in dep:
samples.append(dep)
elif "_java_gapic" in dep:
if "_java_gapic" in dep:
if include_samples:
samples.append(dep + "_samples")
_put_dep_in_a_bucket(dep, client_deps, processed_deps)
_put_dep_in_a_bucket("%s_test" % dep, client_test_deps, processed_deps)
_put_dep_in_a_bucket("%s_resource_name" % dep, proto_deps, processed_deps)
Expand Down