chore: add noxfile parameters for extra dependencies #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add tests for some noxfile parameters for assurance that the template generates valid Python.
tswast
requested review from
a team,
SurferJeffAtGoogle,
bcoe and
chingor13
as code owners
google-cla
bot
added
the
cla: yes
busunkim96
reviewed
Jan 15, 2021
| t = templates.Templates(PYTHON_LIBRARY) | ||
| result = t.render("noxfile.py.j2", **template_kwargs,).read_text() | ||
| # Validate Python syntax. | ||
| result_code = compile(result, "noxfile.py", "exec") |
Contributor
There was a problem hiding this comment.
TIL about the compile() function. Thanks for adding these tests!
busunkim96
approved these changes
Jan 15, 2021
busunkim96
changed the title
Merged
4 tasks
Contributor
Author
|
In addition to the unit tests, I've tried these new parameters out here: googleapis/python-bigquery-storage#118 |
Contributor
|
Tim, Bu Sun approved, so please merge at your earliest convenience. |
Contributor
Author
|
@SurferJeffAtGoogle It looks like Bu Sun isn't in CODEOWNERS. I can't merge.
|
SurferJeffAtGoogle
approved these changes
Jan 26, 2021
Contributor
|
Approved!
…On Tue, Jan 26, 2021 at 9:48 AM Tim Swast ***@***.***> wrote:
@SurferJeffAtGoogle <https://github.com/SurferJeffAtGoogle> It looks like
Bu Sun isn't in CODEOWNERS. I can't merge.
[image: image]
<https://user-images.githubusercontent.com/247555/105883327-580ac500-5fcc-11eb-989c-6ff4a68acbe7.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#906 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZ3TYTVWHE3M65DSNZ4IBDS3356PANCNFSM4WEKVUNA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add tests for some noxfile parameters for assurance that the
template generates valid Python.
Fixes #838