This repository was archived by the owner on Mar 13, 2018. It is now read-only.
Disable selection when dragging the splitter.#4
Open
arv wants to merge 1 commit intogooglearchive:masterfrom
Open
Disable selection when dragging the splitter.#4arv wants to merge 1 commit intogooglearchive:masterfrom
arv wants to merge 1 commit intogooglearchive:masterfrom
Conversation
Merged
Author
There was a problem hiding this comment.
I could not think of a valid reason why this needs to ever be false.
Use preventDefault in mousedown instead of mutating the style
Author
There was a problem hiding this comment.
I was surprised that we do not use leading/trailing underscores for these. They are clearly not part of any public API and it would be nice if we could mark them as such.
Contributor
There was a problem hiding this comment.
is better to use on-down here for both mouse and touch events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use preventDefault in mousedown instead of mutating the style