This repository was archived by the owner on Jan 12, 2019. It is now read-only.
Change queue.handler to send null if the queue has no errors#74
Open
maxrevilo wants to merge 1 commit intogooglearchive:masterfrom
Open
Change queue.handler to send null if the queue has no errors#74maxrevilo wants to merge 1 commit intogooglearchive:masterfrom
maxrevilo wants to merge 1 commit intogooglearchive:masterfrom
Conversation
…as no errors This will make Firebase Util compatible with AngularFire, if queue.handler sends undefined instead of null AngularFire won't trigger the callbacks.
Contributor
Is this a bug in AF? Sounds like it probably is. Is there are error being thrown? |
Contributor
|
Thanks, btw. Looks like a great PR. It will take me a bit to run the tests and get it merged. Ping me if you don't see progress in a week. |
Contributor
Author
|
Ok. No there is no error being thrown. At the beginning I though that was an error in AF, but AF works perfect with firebase.js. AF expects the first parameter of the callbacks to be null if there is no errors, and thats what firebase.js does. For that reason I though that I should try to change Firebase Utils instead of AF. |
Closed
|
This issue fixes issue #56, which continues to vex me. Please merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make Firebase Util compatible with AngularFire, if queue.handler sends
undefinedinstead ofnullAngularFire won't trigger the callbacks.I tried my best with the tests, and I had to change two tests in
test/NormalizedCollection/Record.spec.js.