Skip to content
This repository was archived by the owner on Dec 16, 2025. It is now read-only.

Create Go module. #577

Merged
cassierecher merged 1 commit into from
Jun 9, 2021
Merged

Create Go module. #577

cassierecher merged 1 commit into from
Jun 9, 2021

Conversation

@cassierecher
Copy link
Contributor

@cassierecher cassierecher commented Jun 9, 2021

No description provided.

@shawnbuso shawnbuso self-requested a review June 9, 2021 19:30
@cassierecher
Copy link
Contributor Author

cassierecher commented Jun 9, 2021

Some context notes:

  • This module purposefully is not aware that the code is on v2. I am not certain, but expect this to not be an issue as v1 is not available as a module. If we decide we need v3 in the future, we can start versioning then.
  • I will seek alternative solutions to the problems that caused us to revert the previous attempt at modularization.

@cassierecher cassierecher merged commit 6ebf814 into googlecodelabs:master Jun 9, 2021
@tdashworth tdashworth mentioned this pull request Jun 14, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@shawnbuso shawnbuso shawnbuso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shawnbuso shawnbuso

@DragonRider0o0 DragonRider0o0

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cassierecher @shawnbuso @DragonRider0o0 @googlebot