Conversation
…ore strongly typed
rsheeter
changed the title
rsheeter
changed the title
Contributor
|
In #1684 I made it possible to pass a |
anthrotype
reviewed
Dec 4, 2025
anthrotype
reviewed
Dec 4, 2025
simoncozens
reviewed
Dec 4, 2025
simoncozens
reviewed
Dec 4, 2025
anthrotype
reviewed
Dec 4, 2025
anthrotype
reviewed
Dec 4, 2025
anthrotype
reviewed
Dec 4, 2025
Member
|
I propose we separate input source from the compilation options and restore the ability to generate_font from Before (Rod's PR): pub fn generate_font(args: Args) -> Result<Vec<u8>, Error>
pub fn run(args: Args, timer: JobTimer) -> Result<(), Error>
// where Args contains input: InputAfter: pub fn generate_font(source: Box<dyn Source>, options: Options) -> Result<Vec<u8>, Error> // public library entry point
pub fn run(input: Input, options: Options, timer: JobTimer) -> Result<(), Error> // CLI entry pointI'll make a PR now |
…rce> support Refactor the compile arguments API to: - Rename `fontc::Args` to `fontc::Options` for clarity (avoids confusion with CLI `args::Args`) - Remove `input` field from Options - source is now passed separately - Update `generate_font()` to accept `Box<dyn Source>` + `Options` - Update `run()` to accept `Input` + `Options` This restores the ability to pass custom `Box<dyn Source>` implementations that was added in #1684, which library users need for generating their own IR programmatically. Also: - Add `Default` derive to `Options` for ergonomic in-memory/WASM usage - Rename `cli_args.rs` back to `args.rs` and delete `compile_args.rs` (Options inlined in lib.rs since it's short enough)
Member
see #1797 (which is based on this PR branch, not |
Change require_dir() to use fs::create_dir_all() instead of fs::create_dir() so that nested paths like /tmp/deep/nested/build are created correctly.
…used
When both --emit-ir and --output-file are used, the font is first
written to {ir_dir}/font.ttf by the persistence mechanism. If output_file
differs, we move (rename) the font to the custom output path rather than
leaving it in the IR directory.
We rename (instead of fs::write or fs::copy) as this matches the current
behavior on `main` whereby the font ends up at output_file only and is not
duplicated in the IR directory.
Contributor
Author
Oh good catch, will fix. |
Member
I fixed it in #1797, please take a look at that before duplicating work, thanks! |
Remove input from fontc::Args, rename as Options; restore `Box<dyn Source>` support
Contributor
Author
I feel seen :D |
anthrotype
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aspires toward #1791's goal of making in-memory compiles for wasm happier by making it clearer how to say don't touch the disk
--flag --hereinto a compile arg