Use resolved values for subscript and superscript defaults where needed#1875
Open
Hoolean wants to merge 2 commits intogooglefonts:mainfrom
Open
Use resolved values for subscript and superscript defaults where needed#1875Hoolean wants to merge 2 commits intogooglefonts:mainfrom
Hoolean wants to merge 2 commits intogooglefonts:mainfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happy new year!
A few of the superscript and subscript properties are unusual in that they depend on the resolved value of other attributes: e.g., superscript size should fallback to the explicit subscript size if provided, not just share its default.
This is hopefully an easy +1 for Noto Serif Oriya, which is now happily building at 100% locally : )
Worth noting