Open
Conversation
cmyr
force-pushed
the
variable-notdef-phantoms
branch
from
6883391 to
820f83e
Compare
When os2_typo_ascender/descender vary across masters but the outline ascender/descender are constant, synthesize_notdef was skipping non-default sources entirely, losing the vertical phantom point variation in gvar. Now the variability check also considers the typo metrics, and vertical_origin is set explicitly on all sources.
cmyr
force-pushed
the
variable-notdef-phantoms
branch
from
820f83e to
d745e6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a small issue affecting one font on crater:
When os2_typo_ascender/descender vary across masters but the outline ascender/descender are constant, synthesize_notdef was skipping non-default sources entirely, losing the vertical phantom point variation in gvar. Now the variability check also considers the typo metrics, and vertical_origin is set explicitly on all sources.