Merged
Conversation
Based on internal discussions, this changes the world data schema so that world data is duplicated into each entity. This prevents hot-spotting on world data keyspace, instead allowing a cleaner partition across the entities. BREAKING CHANGE: Changes Spanner schema in backwards incompatible manner.
zmerlynn
added a commit
to zmerlynn/GenAI-quickstart
that referenced
this pull request
Mar 26, 2024
* Adds a Gemma deployment, but it needs an API key. I would like to add a secret, probably in common, that has to be edited before deployment, so I'm not advertising it in the README yet. * After googleforgames#46, secondhand knowledge was reenabled. Disable for now - this needs more prompt work. I tried a couple of things to improve it that are included in this PR but ultimately disabled it again. * Update TGI to 1.4.4
zmerlynn
added a commit
to zmerlynn/GenAI-quickstart
that referenced
this pull request
Mar 26, 2024
* Adds a Gemma deployment, but it needs an API key. I would like to add a secret, probably in common, that has to be edited before deployment, so I'm not advertising it in the README yet. * After googleforgames#46, secondhand knowledge was reenabled. Disable for now - this needs more prompt work. I tried a couple of things to improve it that are included in this PR but ultimately disabled it again. * Update TGI to 1.4.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on internal discussions, this changes the world data schema so that world data is duplicated into each entity. This prevents hot-spotting on world data keyspace, instead allowing a cleaner partition across the entities.
BREAKING CHANGE: Changes Spanner schema in backwards incompatible manner.