Edit Trip Modal Infrastructure#70
Merged
Merged
Conversation
Move to model where there is only SaveTripModal with difference in props passed in.
anan-ya-y
reviewed
Jul 16, 2020
anan-ya-y
approved these changes
Jul 17, 2020
keiffer01
requested changes
Jul 17, 2020
keiffer01
approved these changes
Jul 17, 2020
HiramSilvey
approved these changes
Jul 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is a quick description of the change?
Set up "infrastructure" such that the
SaveTripModaldoes the work of the currentAddTripModaland what would be aEditTripModal.Is this fixing an issue?
none
Are there more details that are relevant?
The Edit Trip modal was split up into two PRs, this one and #73 to avoid one very large PR with potential issues when it came to renaming and making many changes on that renamed file.
SaveTripModalreplacesAddTripModaland does the same work expect now has three additional props:title,tripId, andplaceholderObjthat determine whether the modal will be responsible for adding a new trip or editing an existing trip.Check lists (check
xin[ ]of list items)No unit tests as the only changes are infrastructural/organizational.
As of now, integration (end-to-end) tests were deemed non-critical. Thus, functions related to react and firestore will be tested at a later time. Unit tests for "logical" functions will be included in this PR and for the remaining PRs needed to complete the MVP.
Any additional comments?