Skip to content

Time, part 1: Activity timezone utils and dropdown.#75

Merged
anan-ya-y merged 29 commits into
masterfrom
activity-timeone-dropdown
Jul 27, 2020
Merged

Time, part 1: Activity timezone utils and dropdown.#75
anan-ya-y merged 29 commits into
masterfrom
activity-timeone-dropdown

Conversation

@anan-ya-y
Copy link
Copy Markdown
Collaborator

@anan-ya-y anan-ya-y commented Jul 17, 2020 •
edited
Loading

What is a quick description of the change?

wibbly wobbly timey wimey stuff, part 1.
This PR does the following:

  • Adds moment.js library.
  • Defines constants for time-related operations.
  • Creates "start location" and "end location" dropdowns.
  • Creates timezone selection dropdowns and attempts to link them to the start and end location.

Is this fixing an issue?

Fixes #51, progress on #48.
Fixes #22 (for now..).

Are there more details that are relevant?

{Fill in here or 'none'}

Check lists (check x in [ ] of list items)

  • Test written/updating
  • Tests passing
  • [ ] Coding style (indentation, etc)

Please explain why any are not present, if any.

Any additional comments?

Visual checks for functionality:

  • Timezone and location dropdown should work.
  • Change location and dropdown entries should change.

This PR will have sequels

@anan-ya-y anan-ya-y requested review from keiffer01 and zghera and removed request for zghera July 17, 2020 05:07
keiffer01
keiffer01 requested changes Jul 17, 2020
View reviewed changes
Comment thread frontend/src/components/Utils/time.test.js Outdated
Comment thread frontend/src/components/ViewActivities/editActivity.js Outdated
@anan-ya-y anan-ya-y requested a review from keiffer01 July 20, 2020 14:26
@anan-ya-y anan-ya-y marked this pull request as ready for review July 20, 2020 16:50
zghera
zghera requested changes Jul 20, 2020
View reviewed changes
Comment thread frontend/src/constants/countries.js
Comment thread frontend/src/components/ViewActivities/editActivity.js Outdated
Comment thread frontend/src/components/ViewActivities/editActivity.js Outdated
Comment thread frontend/src/components/Utils/time.js Outdated
Comment thread frontend/src/components/ViewActivities/editActivity.js Outdated
Comment thread frontend/src/components/ViewActivities/editActivity.js
@anan-ya-y anan-ya-y self-assigned this Jul 21, 2020
HiramSilvey
HiramSilvey requested changes Jul 21, 2020
View reviewed changes
Comment thread frontend/src/components/Utils/time.js Outdated
Comment thread frontend/src/components/Utils/time.js
Comment thread frontend/src/components/Utils/time.js
Comment thread frontend/src/components/Utils/time.test.js Outdated
Comment thread frontend/src/components/ViewActivities/activityfns.js Outdated
Comment thread frontend/src/components/ViewActivities/editActivity.js Outdated
Comment thread frontend/src/components/ViewActivities/editActivityFormElements.js Outdated
Comment thread frontend/src/components/ViewActivities/editActivityFormElements.js Outdated
Comment thread frontend/src/components/ViewActivities/editActivityFormElements.js
Comment thread frontend/src/constants/countries.js
@anan-ya-y anan-ya-y requested review from keiffer01 and zghera July 21, 2020 20:54
HiramSilvey
HiramSilvey requested changes Jul 21, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@HiramSilvey HiramSilvey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue or create a separate PR to update the param and return types (when applicable) to include "!" or "?", representing whether they are nullable.

Comment thread frontend/src/components/ViewActivities/activityfns.js Outdated
Comment thread frontend/src/components/ViewActivities/editActivity.js Outdated
Comment thread frontend/src/components/ViewActivities/editActivity.js Outdated
Comment thread frontend/src/components/ViewActivities/editActivity.js Outdated
@zghera zghera mentioned this pull request Jul 21, 2020
Merged
1 task
@anan-ya-y anan-ya-y requested a review from HiramSilvey July 22, 2020 15:57
@zghera zghera mentioned this pull request Jul 23, 2020
Merged
3 tasks
HiramSilvey
HiramSilvey requested changes Jul 24, 2020
View reviewed changes
Comment thread frontend/src/components/ViewActivities/activityfns.js
Comment thread frontend/src/components/ViewActivities/activityfns.js
@anan-ya-y anan-ya-y requested a review from HiramSilvey July 24, 2020 20:36
Base automatically changed from activity-submit-edit to master July 27, 2020 23:16
@anan-ya-y anan-ya-y merged commit e1f8594 into master Jul 27, 2020
@anan-ya-y anan-ya-y deleted the activity-timeone-dropdown branch July 27, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HiramSilvey HiramSilvey HiramSilvey approved these changes

@zghera zghera zghera approved these changes

@beiebi0 beiebi0 Awaiting requested review from beiebi0

@keiffer01 keiffer01 Awaiting requested review from keiffer01

Assignees

@anan-ya-y anan-ya-y

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make timezone dropdown. Pretty format dates

4 participants

@anan-ya-y @HiramSilvey @keiffer01 @zghera