Delete Trips#82
Merged
Merged
Conversation
anan-ya-y
approved these changes
Jul 21, 2020
Collaborator
anan-ya-y
left a comment
anan-ya-y
left a comment
There was a problem hiding this comment.
I like the trip names on your demo.
anan-ya-y
approved these changes
Jul 21, 2020
keiffer01
requested changes
Jul 21, 2020
keiffer01
approved these changes
Jul 22, 2020
HiramSilvey
requested changes
Jul 24, 2020
Collaborator
Author
Issue #93 opened a few days ago for this. |
HiramSilvey
approved these changes
Jul 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is a quick description of the change?
Add functionality to delete a trip and its associated sub-collection of activities
Is this fixing an issue?
None.
Are there more details that are relevant?
The main addition of this PR is to the
ViewTripsdirectory with the following files:trips-container.js: Add new proprefreshTripContainerand pass it as prop to Trip component.trip.js: Add instance of DeleteTripsButton` alongside the other buttons for a trip.delete-trip-button.js: Handles the deletion of a trip and its sub-collection of activities using the methods described in the docs.Check lists (check
xin[ ]of list items)As of now, integration (end-to-end) tests were deemed non-critical. Thus, functions related to react and firestore will be tested at a later time. Unit tests were not written for this PR as there was no (original) "logical" functions written to complete this feature.
Any additional comments?
GIF showing functionality:
