-
Notifications
You must be signed in to change notification settings - Fork 175
Regression: recomposed map listeners ignored #466
Copy link
Copy link
Closed
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.releasedtype: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.releasedtype: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Type
Fields
Give feedbackNo fields configured for issues without a type.
A regression was introduced in 1.4.21, specifically #320, where only the initial compositions of all the GoogleMap listener lambdas are used; recomposed listener lambdas are ignored. This can cause pervasive malfunctions of listener functionality and is a likely cause for some of the issues reported in the last months.
The diff screenshot shows the culprit - the actual Map listener used to call the latest version of the listener lambda, whereas now the actual Map listener is directly set to the initial version of the listener lambda.
I don't know how to trivially fix it without undoing this part of the PR, which would undo the fix for #38. @romainpiel, as the original author of the PR, are you able to devise a way to get recomposed listeners working again?
I am seeing this issue as of maps-compose version 4.3.0, but it has been around since 1.4.21.