Skip to content

Update Android Gradle plugin to 3.6.2#637

Merged
arriolac merged 1 commit intogooglemaps:masterfrom
friederbluemle:update-gradle-plugin
Apr 2, 2020
Merged

Update Android Gradle plugin to 3.6.2#637
arriolac merged 1 commit intogooglemaps:masterfrom
friederbluemle:update-gradle-plugin

Conversation

@friederbluemle
Copy link
Contributor

@friederbluemle friederbluemle commented Feb 25, 2020

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2020
@friederbluemle friederbluemle force-pushed the update-gradle-plugin branch 2 times, most recently from 5790c92 to 33c8cd5 Compare February 25, 2020 19:57
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #637 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #637   +/-   ##
=======================================
  Coverage   39.35%   39.35%           
=======================================
  Files          71       71           
  Lines        4035     4035           
  Branches      606      606           
=======================================
  Hits         1588     1588           
  Misses       2344     2344           
  Partials      103      103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f7b32c...77d01bc. Read the comment docs.

@barbeau
Copy link
Collaborator

barbeau commented Feb 25, 2020

Thanks @friederbluemle! Looks like with this change, though, the project can't be opened in Android Studio 3.5. My preference would be to wait and let Android Studio 3.6 settle a bit before committing to it - especially because there seems to be a regression that breaks Git push again:
https://issuetracker.google.com/issues/124680708#comment15

@friederbluemle friederbluemle changed the title Update Android Gradle plugin to 3.6.0 Update Android Gradle plugin to 3.6.1 Feb 28, 2020
@friederbluemle
Copy link
Contributor Author

Thanks for your comment @barbeau - Makes sense. I don't personally do Git push operations from the IDE, but the issue you mentioned apparently has been fixed in 3.6.1:
https://androidstudio.googleblog.com/2020/02/android-studio-361-available.html
I'll keep this branch rebased until you feel comfortable to merge it.

@friederbluemle friederbluemle changed the title Update Android Gradle plugin to 3.6.1 Update Android Gradle plugin to 3.6.2 Apr 1, 2020
@friederbluemle
Copy link
Contributor Author

Rebased and updated to 3.6.2.

@barbeau
Copy link
Collaborator

barbeau commented Apr 2, 2020

Thanks @friederbluemle! I'm going to close and re-open this to try and nudge Travis into reporting the status...

@barbeau barbeau closed this Apr 2, 2020
@barbeau barbeau reopened this Apr 2, 2020
@friederbluemle
Copy link
Contributor Author

Thanks @barbeau - Looks like the build on Travis CI got kicked off and was successful: https://travis-ci.org/github/googlemaps/android-maps-utils/builds/670187100
So webhooks are set up:
image

But the status did not get reported back: Expected — Waiting for status to be reported.
Maybe Travis needs to be re-authenticated?
I'll try to git commit --amend --no-edit and force push to give it another shot.

@barbeau
Copy link
Collaborator

barbeau commented Apr 2, 2020

@friederbluemle Yeah, I'm not sure what's going on - GitHub just doesn't seem to be getting the reported result from Travis. I'm seeing this on other newer PRs too - for example, #679.

Travis and GitHub statuses seem ok today:

@arriolac arriolac merged commit b1b6849 into googlemaps:master Apr 2, 2020
@friederbluemle friederbluemle deleted the update-gradle-plugin branch April 2, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants