Calling the loader after API has failed does nothing except throw an error. It should retry fetching the library instead

[louisnow]

Calling the loader after API has failed does nothing except throw an error. It should retry fetching the google maps library instead.

Environment details

1. Specify the API at the beginning of the title (for example, "Places: ...")
2. OS type and version: Linux
3. Library version and other environment information: React

Steps to reproduce

1. Block the maps.googleapis.com domain in the browser network tab
2. Call the loader.
3. Unblock the previously blocked domain/URL
4. Call the loader again, it will fail to do anything.

This is important for recovery purposes, google-maps sends a request again if it originally failed and you called the loader again.

[jpoehnelt]

I'll look into adding automatic retries. Unfortunately it seems there isn't much information available as to the cause.

[louisnow]

Would that mean, the original loader that was instantiated first would keep retrying? That would be a nice addition! :)
What about a way to inform the internal singleton that the Loader class was instantiated again and it should retry immediately as well?

[jpoehnelt]

Would that mean, the original loader that was instantiated first would keep retrying? That would be a nice addition! :)

Yes, I have this implemented with tests.

What about a way to inform the internal singleton that the Loader class was instantiated again and it should retry immediately as well?

Adding a reset() that will enable this more easily.

[louisnow]

Adding a reset() that will enable this more easily.

Will it be a public facing api? Would it require us to keep track of the previous/ call .reset() before .load() for every instance of Loader?

Maybe the library can internally call private reset() if the constructor loader is run again and it has already errored out?

[github-actions]

🎉 This issue has been resolved in version 1.10.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀