-
Notifications
You must be signed in to change notification settings - Fork 876
feat: add --upload-content-type flag and smart MIME inference for uploads #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Huglo
wants to merge
1
commit into
googleworkspace:main
Choose a base branch
from
Huglo:feat/upload-content-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+204
−17
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| --- | ||
| "@googleworkspace/cli": minor | ||
| --- | ||
|
|
||
| Add `--upload-content-type` flag and smart MIME inference for multipart uploads | ||
|
|
||
| Previously, multipart uploads used the metadata `mimeType` field for both the Drive | ||
| metadata and the media part's `Content-Type` header. This made it impossible to upload | ||
| a file in one format (e.g. Markdown) and have Drive convert it to another (e.g. Google Docs), | ||
| because the media `Content-Type` and the target `mimeType` must differ for import conversions. | ||
|
|
||
| The new `--upload-content-type` flag allows setting the media `Content-Type` explicitly. | ||
| When omitted, the media type is now inferred from the file extension before falling back | ||
| to the metadata `mimeType`. This matches Google Drive's model where metadata `mimeType` | ||
| is the *target* type (what the file should become) while the media `Content-Type` is the | ||
| *source* type (what the bytes are). | ||
|
|
||
| This means import conversions now work automatically: | ||
| ```bash | ||
| # Extension inference detects text/markdown → conversion just works | ||
| gws drive files create \ | ||
| --json '{"name":"My Doc","mimeType":"application/vnd.google-apps.document"}' \ | ||
| --upload notes.md | ||
|
|
||
| # Explicit flag still available as an override | ||
| gws drive files create \ | ||
| --json '{"name":"My Doc","mimeType":"application/vnd.google-apps.document"}' \ | ||
| --upload notes.md \ | ||
| --upload-content-type text/markdown | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -109,6 +109,7 @@ TIPS: | |
| auth_method, | ||
| None, | ||
| None, | ||
| None, | ||
| matches.get_flag("dry-run"), | ||
| &pagination, | ||
| None, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -99,6 +99,7 @@ TIPS: | |
| auth_method, | ||
| None, | ||
| None, | ||
| None, | ||
| matches.get_flag("dry-run"), | ||
| &pagination, | ||
| None, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation using
std::path::Path::extensiondoesn't handle dotfiles (e.g.,.bashrc,.gitignore) as having an extension, which can lead to incorrect MIME type inference for such files. Usingrsplit_onceon the filename is more robust and correctly identifies extensions for dotfiles. This ensures that MIME type inference works as expected for a wider range of common file naming conventions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The divergence only happens for dotfiles with no stem (.md, .bashrc, .gitignore). The two questions are:
I would suggest to leave the code as is, but happy to take another point of view.