all: IDsFromName to return multiple results

[pierreprinetti]

This patch adds a function in the utils packages that returns all the
IDs of the items with the given name.

This patch leaves the behaviour of the existing IDFromName functions
untouched, while it reduces code duplication.

[pierreprinetti]

I consider this patch ready for review (and possibly, merge). Thank you for your time!

CC @jtopjian

[EmilienM]

very handy!
👍

[kayrus]

I'd sync the code with other services: compute, image, etc.

[jtopjian]

@pierreprinetti

I agree that this is handy - thank you! If it's not too much trouble, @kayrus makes a good point that we should add this for the other resources for consistency. If you don't have the time or desire to do that, just let me know. I'll merge this and then take care of the other resources.

[pierreprinetti]

I submit to the will of the people! 😁

[pierreprinetti]

@jtopjian
If you agree, while I am at it, I am tempted by removing the "if name == name", since we already use ListOpts to filter query results by name. WDYT?

utils/openstack/blockstorage/v3/volumes/utils.go

Line 28 in 94b1932

if s.Name == name {

[pierreprinetti]

That should be it. I have only updated the latest version per package.

Note that I have removed if s.Name == name from the loop when there was a ListOpts that filtered by name already.

Please spend a moment checking that everything is alright, because that's a lot of copy-pasta and I need some backup eyes

[jtopjian]

I've tested everything but the Manila stuff, since I don't have access to a Manila environment. Short of that, this all looks good to me - thanks so much.

[jtopjian]

LGTM - thank you!