feat: add example for telemetry facade#98
Conversation
|
Required label not found on this PR. |
There was a problem hiding this comment.
Can they be run via GitHub action and submit the trace, log, etc. to them? It's better to add some test cases in the tests folder to test the result.
There was a problem hiding this comment.
Yes, I’ll add test cases and examples for manually adding traces and emitting metrics.
hwbrzzl
left a comment
There was a problem hiding this comment.
Hey Bro, I have tested locally. I can only see the traces on jaeger http://127.0.0.1:16686/.
But somethings are missing:
- There are no traces and logs on grafana.
- Traces only contain the http client, but no grpc server:
/->facades.Http().Get("/grpc/user")->grpc UserService.
I had committed my test code. Am I missing anything, please?
iShot_2026-02-14_12.48.15.mp4
|
@hwbrzzl Can you test now? GRPC and HTTP client tracing was not enabled by mistake. In framework repo I was checking |
|
@krishankumar01 Awesome, it worked. Could you add an example for how to add metrics? |
For gRPC and HTTP, metrics are emitted automatically. For custom metrics, I will add an example. |
|
@hwbrzzl I have added an example for metrics in |
|
Hey @krishankumar01 I optimized the test cases, PTAL. |
@hwbrzzl the tests look good and have more variations. |


📑 Description
Closes https://github.com/goravel/goravel/issues/
✅ Checks