Skip to content

feat: add example for telemetry facade#98

Merged
hwbrzzl merged 19 commits intomasterfrom
kkumar-gcc/telemetry
Feb 17, 2026
Merged

feat: add example for telemetry facade#98
hwbrzzl merged 19 commits intomasterfrom
kkumar-gcc/telemetry

Conversation

@krishankumar01
Copy link
Member

📑 Description

Closes https://github.com/goravel/goravel/issues/

✅ Checks

  • Added test cases for my code

@krishankumar01 krishankumar01 requested a review from a team as a code owner February 7, 2026 20:14
@greptile-apps
Copy link

greptile-apps bot commented Feb 7, 2026

Required label not found on this PR.

@krishankumar01 krishankumar01 marked this pull request as draft February 7, 2026 20:35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can they be run via GitHub action and submit the trace, log, etc. to them? It's better to add some test cases in the tests folder to test the result.

Copy link
Member Author

@krishankumar01 krishankumar01 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I’ll add test cases and examples for manually adding traces and emitting metrics.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Bro, I have tested locally. I can only see the traces on jaeger http://127.0.0.1:16686/.
But somethings are missing:

  1. There are no traces and logs on grafana.
  2. Traces only contain the http client, but no grpc server: / -> facades.Http().Get("/grpc/user") -> grpc UserService.

I had committed my test code. Am I missing anything, please?

iShot_2026-02-14_12.48.15.mp4

@krishankumar01
Copy link
Member Author

krishankumar01 commented Feb 14, 2026

@hwbrzzl Can you test now? GRPC and HTTP client tracing was not enabled by mistake. In framework repo I was checking telemetry.instrumentation.grpc_server instead of telemetry.instrumentation.grpc_server.enabled.
image

@krishankumar01
Copy link
Member Author

There are no traces and logs on grafana.

You will need to select the service while searching in Jaeger on Grafana.

image

@hwbrzzl
Copy link
Contributor

hwbrzzl commented Feb 14, 2026

@krishankumar01 Awesome, it worked. Could you add an example for how to add metrics?

@krishankumar01
Copy link
Member Author

@krishankumar01 Awesome, it worked. Could you add an example for how to add metrics?

For gRPC and HTTP, metrics are emitted automatically. For custom metrics, I will add an example.

@krishankumar01
Copy link
Member Author

krishankumar01 commented Feb 14, 2026

@hwbrzzl I have added an example for metrics in user_controller and included steps to run telemetry-related test cases using CI/CD.

@hwbrzzl
Copy link
Contributor

hwbrzzl commented Feb 15, 2026

Hey @krishankumar01 I optimized the test cases, PTAL.

@krishankumar01
Copy link
Member Author

krishankumar01 commented Feb 15, 2026

Hey @krishankumar01 I optimized the test cases, PTAL.

@hwbrzzl the tests look good and have more variations.

@krishankumar01 krishankumar01 marked this pull request as ready for review February 15, 2026 05:09
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@hwbrzzl hwbrzzl merged commit c6e4143 into master Feb 17, 2026
4 checks passed
@hwbrzzl hwbrzzl deleted the kkumar-gcc/telemetry branch February 17, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments