Make the infobox expandable #102 #467
Conversation
Display official blog URL and official jobs URL (#287) as a start.
Abbe98
force-pushed
the
expand-infobox
branch
from
c16bd01 to
fb6ef23
Compare
| <hr> | ||
| <ul> | ||
| <li>Official jobs page: <span class="text-grey" id="additional-link-jobs">[missing data]</span></li> | ||
| <li>Official blog: <span class="text-grey" id="additional-link-blog">[missing data]</span></li> |
There was a problem hiding this comment.
Suggestion: omit the [missing data] from these 2. Because it is not very common those links and if there is something “missing” even if there is none does not come across very well in my opinion.
There was a problem hiding this comment.
I don't agree. This is an invitation to help add the data. And these are just the first few things we add, just with all open issues there may be 3-4 more.
There was a problem hiding this comment.
I'm not a huge fan of this pattern either as a user can see the expand button just to get disappointed. However, people looking to contribute might not even know what they can contribute if we do not indicate this, this is for example a known problem with the call to action buttons. For example if you go to an agency missing an email address there is no way to know from that page that adding an email address will add a button.
For the future I imagine these "missing data" sections(both here and in the existing dialog) to be either accompanied with or replaced by "add"/"+" buttons which would open a modal and let people authenticate with OAuth and paste a new link.
There was a problem hiding this comment.
Yes, I get the idea, but if there is no data to add. Then there is missing data everywhere, but in reality there is none.
There was a problem hiding this comment.
I see, that's indeed an issue and possibly rather common is certain regions. We should probably get rid of all our [missing data] section and add a new general call-to-action about adding new data, such a call-to-action could then go on to tell the potential contributor of all the data we can display. That would also solve the issues with the buttons without us introducing some new UI-pattern.
Regarding this PR; I will change it so that no button is rendered if there is no data in the expandable section.
|
I was trying to build locally but got this error: |
Looks like WDQS is having a bad day. |
Ainali
left a comment
Ainali
left a comment
There was a problem hiding this comment.
Worked on the second try!
(Not a blocker, but if in the future the expanded view gets long, we might want to have an option to collapse it again. But let's merge this for now.)
|
Converted to draft until I have changed it so that the "expand" button only renders when there is additional data to be displayed. I will also create an issue about a generic "[missing data]" (or something positive? "add information"?) replacement. |
|
I'm scratching my head a little bit regarding the design here. If we only want to display this if there is information we end up in a situation in which we either show a loading indicator and a "fail message" or we end up with a jumpy behavior when the "expand" renders. I'm not a fan of either. Maybe if we first turn the [missing data] messages into a call to action "[add information->]" it's more acceptable to always show this even if there is no additional information? |
Description
Display official blog URL and official jobs URL (#287) as a start.
Issue Reference
Fixes #102 #287
PR Details
Type of Change
Checklist
Please ensure the following before submitting the PR:
Screenshots (applicable to user interface changes)
Screencast from 2024-12-08 17-06-18.webm
Screencast from 2024-12-08 17-05-58.webm