Skip to content

Conversation

@RVA2869
Copy link
Collaborator

@RVA2869 RVA2869 commented Apr 15, 2025

Description

Email address also needs a reference.

Issue Reference

In addition to #509

@Ainali
Copy link
Member

Ainali commented Apr 15, 2025

As far as I can see, on line 18 in organization-optional.rq, no reference is needed for the email.

Perhaps we should have that, but we don't yet.

@RVA2869
Copy link
Collaborator Author

RVA2869 commented Apr 15, 2025

As far as I can see, on line 18 in organization-optional.rq, no reference is needed for the email.

Perhaps we should have that, but we don't yet.

Are you sure about this?
Because I have come across an email address without a reference a few times and it was not displayed on the website.
I asked about this on the GD telegram and you replied that it was intentional/by design (not a bug)

@Ainali
Copy link
Member

Ainali commented Apr 15, 2025

I thought it was like that too earlier, but @Abbe98 looked it up in our collab call last Friday and as you can see in the query I linked, no reference is needed. If you have any examples of emails not displaying, please share those so that we can investigate.

@RVA2869
Copy link
Collaborator Author

RVA2869 commented Apr 15, 2025

Strange... If I come across any more I'll be sure to report it.😉

@RVA2869
Copy link
Collaborator Author

RVA2869 commented Apr 18, 2025

Perhaps we should have that

I agree that if it is required on Wikidata, it should also be required on Govdirectory.

@RVA2869
Copy link
Collaborator Author

RVA2869 commented May 9, 2025

OPTIONAL { ?org wdt:P968 ?email . ?org p:P968 ?emailStatement . ?emailStatement (ps:P968) [] . FILTER(EXISTS { ?emailStatement prov:wasDerivedFrom ?reference. }) }

Something like this? I used the phone query as an example.

@Abbe98
Copy link
Member

Abbe98 commented May 9, 2025

Yeah that looks right, I would however, be curious what the impact would look like. Maybe we first need to spend some time adding references to Wikidata so we don't lose these contact points...

@RVA2869
Copy link
Collaborator Author

RVA2869 commented May 9, 2025

Wouldn't the loss be minimal? + I have no idea how many email addresses we have at the moment.

@Abbe98
Copy link
Member

Abbe98 commented May 19, 2025

That's the question, I will give it a try tomorrow when the current deployment is done.

@RVA2869 RVA2869 added the documentation ✍️ Improvements or additions to documentation label Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation ✍️ Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants