Skip to content

Conversation

@Rahul2322-P
Copy link

Made a small update to improve how we pull the head of an institution:

-->Added a few fallback properties like chair (P488), CEO (P169), director (P1037), and Secretary-General (P3975)
-->Also added a COALESCE so if the name’s missing, it’ll show “Not Available” instead
This should help keep the results meaningful even when the main leader info isn’t there.
Appreciate you taking the time to review it!

@Rahul2322-P
Copy link
Author

Hey @Ainali,

I’ve made the requested updates:

-->Split the office (P2388, P1313) and person-based properties (P488, P169, P1037, P3975) into separate blocks.

-->Removed the COALESCE fallback, since the frontend handles missing data.

Everything should now work as expected. Please have a look when you get a chance. Thanks!

@Ainali
Copy link
Member

Ainali commented Oct 30, 2025

-->Removed the COALESCE fallback, since the frontend handles missing data.

It looks like you forgot to remove it.

@Rahul2322-P
Copy link
Author

Hi @Ainali — I’ve now removed the COALESCE fallback from ?leadBy as requested.
Everything else is unchanged. Please review when you get a chance. Thanks!

@Rahul2322-P
Copy link
Author

Hi @Ainali,
I’ve pushed the latest commit removing the COALESCE fallback as you requested.
All checks are passing and there are no conflicts.
Could you please review and approve when you get a chance?
Thank you!

@Ainali
Copy link
Member

Ainali commented Nov 1, 2025

@Rahul2322-P Have you tried these changes locally?

Copy link
Member

@Ainali Ainali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked around on a number of countries when running this locally, and it adds a bunch of new lead by correctly, and I cannot see that it breaks anything else either, so I'll approve it but I hope that @Abbe98 could double-check so I am not missing anything.

@Ainali Ainali requested a review from Abbe98 November 1, 2025 10:30
@Rahul2322-P
Copy link
Author

Thanks @Ainali for the approval and local test confirmation.
I’ll wait for @Abbe98’s review to make sure everything is aligned before merge.
Appreciate your time!

@Ainali
Copy link
Member

Ainali commented Nov 1, 2025

Thanks @Ainali for the approval and local test confirmation.

I would still appreciate an answer if you tried this locally.

@Rahul2322-P
Copy link
Author

Thanks, @Ainali!
I ran local tests on my end too — checked multiple country entries to confirm the fallback logic and lead_by additions behave as expected without breaking anything else.
I'll hold off on merging until @Abbe98 gives the green light, just to be sure everything lines up.
Really appreciate your thorough review and the extra eyes!

@Ainali
Copy link
Member

Ainali commented Nov 1, 2025

I'll hold off on merging

That's odd. You shouldn't even have the rights to merge.

@RVA2869 RVA2869 added enhancement 🥇 New feature or request data 💻 work related to data improvements or investigations labels Nov 1, 2025
@Rahul2322-P
Copy link
Author

Thanks everyone for reviewing. Everything looks good on my end and the tests confirm expected behavior. I’ll hold off until @Abbe98 gives the final go-ahead. Really appreciate the quick feedback and the labels!

@Rahul2322-P
Copy link
Author

Hi @Abbe98
--> just following up to see if you had a chance to review this. It’s already approved by @Ainali and verified locally on both ends. Appreciate your time.

@Ainali
Copy link
Member

Ainali commented Nov 4, 2025

Hi @Abbe98 --> just following up to see if you had a chance to review this. It’s already approved by @Ainali and verified locally on both ends. Appreciate your time.

Chill. Spamming with comments does not help anyone. (Don't reply to this comment either.)

Copy link
Member

@Abbe98 Abbe98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming they are in the priority order (left to right, SAMPLE will always pick the first one) we want, I'm okay with this.

Two line breaks are left to be cleaned up, but that's it.

@Rahul2322-P
Copy link
Author

Thanks @Abbe98
I will cleaned up the extra line breaks as requested.
Please let me know if it looks good now.

@Rahul2322-P
Copy link
Author

Hi @Abbe98 — just following up to check if the cleanup looks good now.
Everything’s updated and verified locally. Appreciate your time and review!

@Abbe98
Copy link
Member

Abbe98 commented Nov 14, 2025

There is still a odd line in the OPTIONAL section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data 💻 work related to data improvements or investigations enhancement 🥇 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants