Skip to content

Conversation

@RVA2869
Copy link
Collaborator

@RVA2869 RVA2869 commented Dec 12, 2025

Description

Added a few new (sub)types and updated the expected number of organizations.

Checklist

Please ensure the following before submitting the PR:

  • I have tested the changes locally, and they work as expected.
  • The code follows the project's coding standards and conventions.
  • I have added unit tests or performed manual testing where necessary.

Added new organization types for Scottish executive agencies, non-departmental public bodies, advisory bodies, non-ministerial offices, and public corporations. Updated expected result count.
Copy link
Member

@Ainali Ainali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

We should also update the description for Scotland in countries.rq so that it matches what we are querying for now.

@RVA2869 RVA2869 requested a review from Ainali December 12, 2025 15:37
@RVA2869
Copy link
Collaborator Author

RVA2869 commented Dec 12, 2025

Please note: Q137189644 has not been included because Wikipedia states: Merger of Scottish Qualifications Authority, but I could not find any reference to the change on the Scottish Qualifications Authority website and other government websites. (This is a problem for future me 😉)

@Ainali Ainali merged commit 6f4acd4 into govdirectory:main Dec 12, 2025
2 checks passed
@RVA2869 RVA2869 deleted the Update-Scotland branch December 12, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants