Skip to content

feat(payment): implement department-specific API key management and configuration#17

Merged
Ethical-Ralph merged 1 commit intodevelopfrom
feat/multi-payment-api-key
Dec 16, 2025
Merged

feat(payment): implement department-specific API key management and configuration#17
Ethical-Ralph merged 1 commit intodevelopfrom
feat/multi-payment-api-key

Conversation

@Ethical-Ralph
Copy link
Collaborator

Description

Implemented a department-based API key mapping system for EZPay payment integration.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Changes Made

  • Added support for multiple department-specific API keys
  • Simple service that maps department names to API keys
  • Handles fallback to default API key if department key is missing
  • Modified all methods to accept optional custom API keys
  • Automatically selects correct API key based on department
  • Passes department-specific API key to EZPay service

@amazon-inspector-n-virginia
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-n-virginia
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@Ethical-Ralph Ethical-Ralph merged commit b0ca019 into develop Dec 16, 2025
1 of 2 checks passed
*/
private extractDepartmentFromReference(reference: string): string | null {
// Check if reference follows the department format
const match = reference.match(/^([A-Z_]+)-(.+)-(.+)$/);

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
a user-provided value
may run slow on strings starting with 'A-a-' and with many repetitions of 'a-a'.
This
regular expression
that depends on
a user-provided value
may run slow on strings starting with 'A-a-' and with many repetitions of 'a-a'.
This
regular expression
that depends on
a user-provided value
may run slow on strings starting with 'A-a-' and with many repetitions of 'a-a'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant