feat: Add saving form submissions to google sheet#36
Open
feat: Add saving form submissions to google sheet#36
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
![amazon-inspector-n-virginia[bot]](https://avatars.githubusercontent.com/u/214039647?s=60&v=4){kind=small}
| .replace(/([A-Z])/g, ' $1') // Add space before capitals | ||
| .replace(/[_-]/g, ' ') // Replace underscores and hyphens with spaces | ||
| .trim() | ||
| .replace(/^\w/, (c) => c.toUpperCase()); // Capitalize first letter |
There was a problem hiding this comment.
Description: Cross-site scripting vulnerability detected. User input is being used in HTML output without proper sanitization.
This could lead to session hijacking, malware installation, or phishing attacks.
Always sanitize and encode user inputs before including them in output using context-appropriate encoding methods.
Severity: High
|
✅ I finished the code review, and left comments with the issues I found. |
| "config": { | ||
| "spreadsheetId": "{{db:exit-survey:spreadsheet_id}}", | ||
| "sheetName": "Responses", | ||
| "fields": [ |
Collaborator
There was a problem hiding this comment.
what if we do something like this
Suggested change
| "fields": [ | |
| "fields": [ | |
| { | |
| "title": "Timestamp", | |
| "key": "_timestamp" | |
| } | |
| ] |
Contributor
Author
There was a problem hiding this comment.
I don't mind that. Do you want to submit an update?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update form processor to optionally save form submission to specified google sheet
Type of Change
Changes Made
Notes
Testing
Related Github Issue(s)/Trello Ticket(s)
https://trello.com/c/eBxlufOF/112-update-exit-survey-form-processing-api
Checklist