feat (forms): add "apply to be temp teacher" form#51
Open
IsaiahSama wants to merge 15 commits intodevelopfrom
Open
feat (forms): add "apply to be temp teacher" form#51IsaiahSama wants to merge 15 commits intodevelopfrom
IsaiahSama wants to merge 15 commits intodevelopfrom
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
sajclarke
changed the title
IsaiahSama
force-pushed
the
govtech-bb/feat/apply_to_be_temp_teacher
branch
from
c99b56e to
27311ca
Compare
src/email/templates/.djlintrc
Outdated
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "extension": "html.hbs", | |||
| "indent": "2", | |||
Contributor
Author
There was a problem hiding this comment.
No please, I thought that was Git Ignored.
Thanks for pointing that out
Ethical-Ralph
requested changes
Jan 16, 2026
Collaborator
Ethical-Ralph
left a comment
Ethical-Ralph
left a comment
There was a problem hiding this comment.
The email template doesn't match the schema
IsaiahSama
force-pushed
the
govtech-bb/feat/apply_to_be_temp_teacher
branch
from
105dc16 to
9c26d81
Compare
IsaiahSama
force-pushed
the
govtech-bb/feat/apply_to_be_temp_teacher
branch
from
9c26d81 to
364705c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added backend schema validation for the form "Apply to be a Temporary Teacher"
Type of Change
Changes Made
schema/temporary-teacher-application.json: Created the validation schemasrc/email/templates/temporary-teacher-application.hbs: Email Template for adminssrc/email/templates/temporary-teacher-application-receipt.hbs: Email template for recipientsNotes
Testing
Related Github Issue(s)/Trello Ticket(s)
Trello #71
Checklist