Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
IsaiahSama
reviewed
Jan 19, 2026
| "required": true | ||
| }, | ||
| { | ||
| "name": "telephoneNumber", |
Contributor
There was a problem hiding this comment.
Will there be validation for telephone number on the backend?
Contributor
Author
There was a problem hiding this comment.
Yes can you please open a PR to address this?
IsaiahSama
approved these changes
Jan 19, 2026
Contributor
IsaiahSama
left a comment
There was a problem hiding this comment.
See comment about Telephone number validation, otherwise, all good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR restructures the Community Sports Programme form schema to use nested object grouping, improving form organization and data structure clarity. The schema changes consolidate related fields into logical sections such as applicant information, discipline details, employment, contact information, and emergency contact details.
Type of Change
Changes Made
firstName→applicant.firstName)gendertosexfor consistencydisciplineOfInteresttodiscipline.areaOfInterestdisciplineExperiencetodiscipline.hasExperiencewith yes/no validationexperienceLeveltoexperience.levelOfExperienceyearsOfExperiencetoexperience.yearsOfExperienceemploymentStatustoemployment.statusemployerNametoemployment.companyNameotherEmploymentDetailstoemployment.otherDetailsbelongsToOrganizationstobelongsToOrganisationswith yes/no validationorganizationNamesarray toorganizationDetailswithorganizationNameandhasSignificantPositionpropertiesemergencyobject with nested structurecontactobject with nested structure{{formData.applicant.firstName}})Files Changed
Notes
This is a breaking change that requires form data to be submitted with the new nested structure. The email processor has been updated to reference fields using the new nested paths. Existing form submissions and stored data may need migration depending on the database schema.
Testing
Related Github Issue(s)/Trello Ticket(s)
Checklist