Skip to content

fix: complete email template audit and add applicant confirmation emails#60

Merged
Ethical-Ralph merged 1 commit intodevelopfrom
fix/email-templates-audit-and-applicant-confirmation
Jan 20, 2026
Merged

fix: complete email template audit and add applicant confirmation emails#60
Ethical-Ralph merged 1 commit intodevelopfrom
fix/email-templates-audit-and-applicant-confirmation

Conversation

@Ethical-Ralph
Copy link
Collaborator

Description

  • Create missing admin template for fire-service-inspection form
  • Fix 7 incomplete admin templates with missing form fields:
    • apply-for-conductor-licence: add licence history, endorsements, disqualifications
    • community-sports-registration: add email field
    • jobstart-plus-programme: add emergency, education, employment, eligibility sections
    • sell-goods-services-beach-park-notice: add selling, business, referee sections
    • reserve-company-name: add company name choices, remove copy-paste errors
    • post-office-redirection-notice: handle all 3 form types
    • primary-school-textbook-grant: fix schema/template structure mismatch
  • Add email and telephoneNumber fields to get-birth-certificate and get-marriage-certificate schemas
  • Create 17 applicant confirmation receipt templates
  • Add applicant confirmation email processors to 17 schemas

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Changes Made

Notes

Testing

  • Manual tests completed
  • Added unit tests
  • Added e2e tests

Related Github Issue(s)/Trello Ticket(s)

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Documentation updated

@amazon-inspector-n-virginia
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-n-virginia
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

Copy link
Contributor

@sajclarke sajclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ethical-Ralph Ethical-Ralph merged commit 8d94892 into develop Jan 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants