Fix (form): Fixed issue causing declaration page to not render correctly#72
Merged
Fix (form): Fixed issue causing declaration page to not render correctly#72
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
phrogwrld
approved these changes
Jan 28, 2026
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Declaration page for Protege form was rendering the fallback, due to the renderer looking for
applicant.firstNameandapplicant.lastName, however, the Protege form usedpersonal.As such, converted the
personalfield to beapplicant, so that we could have consistent behaviour between forms, by updating the backend schema, and email templates.Type of Change
Changes Made
schemas/project-protege-mentor.jsonsrc/email/templates/project-protege-mentor.hbssrc/email/templates/project-protege-mentor-receipt.hbsPersonal was changed to Applicant, to ensure consistency.
Notes
Testing
Related Github Issue(s)/Trello Ticket(s)
Trello #138
Checklist