Fix (Form): Update certificate admin emails#74
Conversation
IsaiahSama
requested review from
Ethical-Ralph,
jacksheppard-PD,
phrogwrld and
sajclarke
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
![amazon-inspector-n-virginia[bot]](https://avatars.githubusercontent.com/u/214039647?s=60&v=4){kind=small}
src/email/email.service.ts
Outdated
| Handlebars.registerHelper('titleCase', function(...args) { | ||
| const values = args.slice(0, -1); | ||
| const titled = values.map(str => str.toLowerCase() | ||
| .replace(/\b\w/g, (char: string) => char.toUpperCase())) |
There was a problem hiding this comment.
Description: Cross-site scripting vulnerability detected. User input is being used in HTML output without proper sanitization.
This could lead to session hijacking, malware installation, or phishing attacks.
Always sanitize and encode user inputs before including them in output using context-appropriate encoding methods.
Severity: High
|
✅ I finished the code review, and left comments with the issues I found. |
phrogwrld
left a comment
phrogwrld
left a comment
There was a problem hiding this comment.
@IsaiahSama you would have to play around these changes I suggested, since I don't know how the email renders
| body { | ||
| font-family: -apple-system, BlinkMacSystemFont, 'Figtree', 'Segoe UI', | ||
| Roboto, 'Helvetica Neue', Arial, sans-serif; | ||
| color: #333; |
There was a problem hiding this comment.
for the css reset all fonts are black-00 on figma
| color: #333; | |
| color: #000; |
3 participants
Description
Update the MDA email templates for: Birth Certificate, Marriage Certificate, and Death Certificate.
Type of Change
Changes Made
Notes
Testing
Related Github Issue(s)/Trello Ticket(s)
MDA Email for Marriage Certificate
MDA Email for Death Certificate
MDA Email for Birth Certificate
Checklist