Skip to content

Update (Form): Updated schema and email template to match changes for redirect-business-mail#81

Merged
phrogwrld merged 1 commit intodevelopfrom
chore/redirect-business-mail-changes
Jan 29, 2026
Merged

Update (Form): Updated schema and email template to match changes for redirect-business-mail#81
phrogwrld merged 1 commit intodevelopfrom
chore/redirect-business-mail-changes

Conversation

@IsaiahSama
Copy link
Contributor

Description

Updated Schema and Email templates for post office redirection, performing the following:

  • Changing permissionDetails to positionDetails
  • Removing validation for uploadDocuments
  • Added validation for applicant idNumber and passportNumber

Type of Change

  • Bug fix
  • New feature
  • Breaking change: Payloads in Postman need to be reviewed
  • Documentation update

Changes Made

  • schemas/post-office-redirection-business.json
  • src/email/templates/post-office-redirection-notice.hbs

Notes

Testing

  • Manual tests completed
  • Added unit tests
  • Added e2e tests

Related Github Issue(s)/Trello Ticket(s)

Re: PR 405

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Documentation updated

@amazon-inspector-n-virginia
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-n-virginia
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@IsaiahSama IsaiahSama changed the title Updated schema and email template to match changes Update (Form): Updated schema and email template to match changes for redirect-business-mail Jan 29, 2026
@IsaiahSama IsaiahSama force-pushed the chore/redirect-business-mail-changes branch from 2342370 to 62a706a Compare January 29, 2026 23:17
Copy link
Contributor

@phrogwrld phrogwrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phrogwrld phrogwrld merged commit 070d868 into develop Jan 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants