Skip to content

Feat (Forms): Can now send emails to schools based on selected school#95

Merged
phrogwrld merged 6 commits intodevelopfrom
feat/update-school-email-target
Feb 5, 2026
Merged

Feat (Forms): Can now send emails to schools based on selected school#95
phrogwrld merged 6 commits intodevelopfrom
feat/update-school-email-target

Conversation

@IsaiahSama
Copy link
Contributor

Description

  • Updated schema to match updated frontend design.
  • Added a constants file that can be used to access static data dynamically
  • Added support for parsing access to these constant values
  • Added documentation explaining how to use the feature

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Changes Made

  • src/email/templates/primary-school-textbook-grant.hbs
  • schemas/primary-school-textbook-grant.json
  • src/common/constants/constants.ts
  • src/forms/expression-resolver.service.ts
  • src/forms/README.md

Notes

Testing

  • Manual tests completed
  • Added unit tests
  • Added e2e tests

Related Github Issue(s)/Trello Ticket(s)

Trello

Relies on Frontend PR 423

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Documentation updated

@amazon-inspector-n-virginia
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-n-virginia
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

Copy link
Contributor

@phrogwrld phrogwrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phrogwrld phrogwrld merged commit 2396e89 into develop Feb 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants