Allow a popup page as the download page#23
Merged
EBusch merged 5 commits intofeature/prevent-auto-finishfrom Jul 25, 2022
Merged
Allow a popup page as the download page#23EBusch merged 5 commits intofeature/prevent-auto-finishfrom
EBusch merged 5 commits intofeature/prevent-auto-finishfrom
Conversation
mediabounds
requested changes
Jul 22, 2022
bbeversdorf
approved these changes
Jul 25, 2022
bbeversdorf
left a comment
bbeversdorf
left a comment
There was a problem hiding this comment.
In general, this looks(?) pretty safe. It will need a thorough run thru though.
| downloadStatus.DownloadsCancelled += HandleDownloadCancelled; | ||
|
|
||
| NavigationContext.PresentPage(CreateDownloadStatusPage(downloadStatus)); | ||
| await ShowDownloadStatus(CreateDownloadStatusPage(downloadStatus)); |
There was a problem hiding this comment.
@EBusch Could we get into a state where we are creating/presenting the download page more than once?
just wondering if we need a protection from creating multiple
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.